Update management --> models --> datatype #5674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-tincas
requested changes
Dec 4, 2023
Contributor
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
Hi @erikjanwestendorp thank you for the PR as always #h5YR
I have a suggestion, can you please take a look at it and let me know what you think? If you agree with it, can you please change it for all versions? 😊
Co-authored-by: Alina-Magdalena Tincas <83591955+alina-tincas@users.noreply.github.com>
Contributor
Author
|
@alina-tincas Thanks for your review, just updated the PR with your suggestion. Also updated version 11, 12 & 13. |
alina-tincas
approved these changes
Dec 4, 2023
Contributor
|
Awesome, thank you 🙌 All looks good now so am merging it in 💪 |
Contributor
|
@erikjanwestendorp v11 is currently EOL . So in this case it is not necessary anymore to make any changes to v11 docs going forward 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates:
Type of suggestion
Product & version (if relevant)
Umbraco v10, 11, 13 & 13