-
Notifications
You must be signed in to change notification settings - Fork 811
Add section about external login providers on Cloud #6395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @sofietoft 🙌 I have a few minor suggestions.
However, I think the Note might be a bit too long.
How about keeping just the first two sentences in the Note, and moving the rest of the information/steps below it?
Alternatively, you could add it as a sub-section, which would create a heading in the right navigation and make it easier to find.
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Thanks for the review @eshanrnh - So, a bit of "history" here: I'm not a fan of the formatting of the text within the note, so I'm happy with changing it back! |
Ah, I see... 🙈 It might be a good idea to shorten the Note, or maybe use expandable sections? Right now, the lists and code snippets are making it feel a bit overwhelming, which takes away from the purpose of highlighting important info in the Note. I’ll leave it up to you to decide the best formatting for the text 😀 |
@eshanrnh - I've taken it out of the note. I'll merge it, if you have no further comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please feel free to merge it in.
Description
Additional configuration is required for using External Login Providers on Cloud.
I added this information in a note.
Type of suggestion