Skip to content

Conversation

@erikjanwestendorp
Copy link
Contributor

Description

This PR belongs to: #6466. Change UmbracoApiController to a default Controller and also added route attributes as suggested in the Porting old Umbraco API Controllers article. Happy hacktoberfest! 🎃

UmbracoApiController

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco CMS v14 & 15

@erikjanwestendorp
Copy link
Contributor Author

@sofietoft I don't know how to check off the task in the issue🙈

@sofietoft
Copy link
Contributor

Amazing @erikjanwestendorp ! Thanks 😄
I'll make sure we review it as soon as possible.

I've checked the article in the list on the Issue.
I think I'll have to add the checkmarks, due to the privacy settings on the repo 🙈

@sofietoft
Copy link
Contributor

sofietoft commented Oct 2, 2024

I've tested the code now, and it compiles (with a few warnings, but nothing related to the "missing" API Controller) 👏 🎉

And great idea adding the suggestions from the Porting article 💪 Makes a whole lot of sense!

I'll get this merged!

@sofietoft sofietoft merged commit 34df767 into umbraco:main Oct 2, 2024
@sofietoft sofietoft mentioned this pull request Oct 2, 2024
5 tasks
@erikjanwestendorp erikjanwestendorp deleted the update-extending-database branch October 2, 2024 11:31
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @erikjanwestendorp!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25nd, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants