Skip to content

Conversation

@erikjanwestendorp
Copy link
Contributor

Description

This PR belongs to: #6466.

  • Change UmbracoApiController to Controller
  • Remove using statement 'using Umbraco.Cms.Web.Common.Controllers;'
  • Add Attributes
  • Get Content by Key/Guid
  • Update BlockGridElementData (Due to serialization issues)
  • Delete obsolete message
  • css to css (prevents style guide warnings, I think it is good to be careful with capitalization here because of case sensitive hosting environments)

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Styleguide

Product & version (if relevant)

Umbraco CMS v14 & 15

@sofietoft
Copy link
Contributor

Thanks @erikjanwestendorp ! 💪
We'll get this reviewed as soon as possible.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a chance to test this out, and I can only get it to compile if I do not make the changes you're adding to the BlockGridElementData (line 613) in the Model..cs file 🤔

It gives me the following error: Property or indexer 'BlockGridElementData.Data' cannot be assigned to -- it is read only

Perhaps it is not needed to change this method? 🤔

@sofietoft
Copy link
Contributor

Did you see my comments on this one, @erikjanwestendorp ? 😄

@erikjanwestendorp
Copy link
Contributor Author

@sofietoft sorry for the delay on this one! 🙈 Just updated the PR 😄

@sofietoft
Copy link
Contributor

Everything checks out 😄 🎉

Thanks again @erikjanwestendorp !

I'll get this merged right away!

@sofietoft sofietoft merged commit d9dfc25 into umbraco:main Oct 22, 2024
42 checks passed
@erikjanwestendorp erikjanwestendorp deleted the update-block-grid branch October 22, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants