Skip to content

Conversation

@jemayn
Copy link
Contributor

@jemayn jemayn commented Oct 12, 2024

Description

I've gone through the package documentation and found that there are some very outdated things that haven't been valid since v8 in the current versions.

I've cleaned up for versions 13, 14 & 15.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

@sofietoft
Copy link
Contributor

Thanks for the PR @jemayn !

We will review it as soon as possible.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this @jemayn ! 💪

I've left a single comment. Let me know if something doesn't make sense!
I'm happy to take care of the changes as well if you want. Just let me know! 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When deleting articles, we also need to delete the reference to them in the SUMMARY file.
So, for each time you've deleted a file, remove the reference to that file in the "nearest" SUMMARY file:

13/umbraco-cms/SUMMARY.md
14/umbraco-cms/SUMMARY.md
15/umbraco-cms/SUMMARY.md

If not, GitBook will just create a blank article with a heading 🙈
Also, we should add redirects, just in case. Use the 13/umbraco-cms/.gitbook.yaml file for that! I'm happy to do that as well - just let me know what you prefer 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yep, makes sense!

I've done it in 9ebdb4c - I couldn't find it in the v15 summary file but a lot is missing in that one so I assumed you use it to know what's been tested, etc. 🙂

Let me know if anything is still missing!

@jemayn jemayn requested a review from sofietoft October 16, 2024 08:04
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks @jemayn ! 🙌
Everything looks great.

And yes, the SUMMARY for 15 is slimmed down for the RC at the moment.
I'll merge it with the others once we release the final 15 😁

Thanks again for getting these articles up to speed.
I'll get it merged!

@sofietoft sofietoft merged commit ff08a7e into umbraco:main Oct 16, 2024
26 checks passed
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @jemayn!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants