-
Notifications
You must be signed in to change notification settings - Fork 811
Update migrate-from-umarketingsuite.md #6633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added some changes to the guide after going through it
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jette94 !
I've added some suggestions and questions.
Please take a look when you have a minute.
| * `Assets/Umbraco.Engage/Scripts/umbracoEngage.ga4-bridge.js` | ||
| * `Assets/Umbraco.Engage/Scripts/umbracoEngage.blockerdetection.js` | ||
| * The Cockpit Partial View has been moved to: | ||
| * The Cockpit Partial View has been moved, and needs to be changed to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one.
Do you need to move the files yourself, or do they need to be renamed or changed? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By replacing the uMarketingSuite Cockpit with Engage, the location will change - therefor you will need to change the path of the cockpit in the template :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! And which template is this exactly?
Just wondering if we should make that clearer, as currently it sounds like something needs to be moved to change a path 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the template for the page setup! If set up in a master template, that would be it. It needs to be in the bottom of the tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Should we do something like this instead then:
"The Cockpit partial view has been moved, and any references should be changed to:"
Co-authored-by: sofietoft <stk@umbraco.com>
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering the suggestions.
Did you see my suggestion to move the note about Cloud ABOVE the list?
| * `Assets/Umbraco.Engage/Scripts/umbracoEngage.ga4-bridge.js` | ||
| * `Assets/Umbraco.Engage/Scripts/umbracoEngage.blockerdetection.js` | ||
| * The Cockpit Partial View has been moved to: | ||
| * The Cockpit Partial View has been moved, and needs to be changed to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! And which template is this exactly?
Just wondering if we should make that clearer, as currently it sounds like something needs to be moved to change a path 😅
Co-authored-by: sofietoft <stk@umbraco.com>
Added some changes to the guide after going through it
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?