Skip to content

Conversation

@Jette94
Copy link
Contributor

@Jette94 Jette94 commented Nov 7, 2024

Added some changes to the guide after going through it

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

Added some changes to the guide after going through it
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jette94 !

I've added some suggestions and questions.
Please take a look when you have a minute.

* `Assets/Umbraco.Engage/Scripts/umbracoEngage.ga4-bridge.js`
* `Assets/Umbraco.Engage/Scripts/umbracoEngage.blockerdetection.js`
* The Cockpit Partial View has been moved to:
* The Cockpit Partial View has been moved, and needs to be changed to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one.
Do you need to move the files yourself, or do they need to be renamed or changed? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By replacing the uMarketingSuite Cockpit with Engage, the location will change - therefor you will need to change the path of the cockpit in the template :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! And which template is this exactly?
Just wondering if we should make that clearer, as currently it sounds like something needs to be moved to change a path 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the template for the page setup! If set up in a master template, that would be it. It needs to be in the bottom of the tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Should we do something like this instead then:

"The Cockpit partial view has been moved, and any references should be changed to:"

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the suggestions.

Did you see my suggestion to move the note about Cloud ABOVE the list?

* `Assets/Umbraco.Engage/Scripts/umbracoEngage.ga4-bridge.js`
* `Assets/Umbraco.Engage/Scripts/umbracoEngage.blockerdetection.js`
* The Cockpit Partial View has been moved to:
* The Cockpit Partial View has been moved, and needs to be changed to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! And which template is this exactly?
Just wondering if we should make that clearer, as currently it sounds like something needs to be moved to change a path 😅

@sofietoft sofietoft merged commit 06542f2 into umbraco:main Nov 13, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants