-
Notifications
You must be signed in to change notification settings - Fork 811
Updated accepted prefix with new one for products #6674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * `Umbraco__Forms__FieldTypes__Recaptcha` | ||
| * `Umbraco__CMS__Integrations` | ||
| * `Umbraco__CMS__DeliveryAPI` | ||
| * `UMBRACO__LICENSES__YOURPRODUCT` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * `UMBRACO__LICENSES__YOURPRODUCT` | |
| * `UMBRACO__LICENSES__` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pijemcolu wouldnt it be more clear to customers that they can add it for the different products with YOURPRODUCT at the end?
They might want to have more than one license in their projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do UMBRACO__LICENSES__XX as an alternative.
And then in a note below, we mention how to replace XX with the product name and give an example or two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a set of prefixes. This is a set of prefixes (Ok, we can improve slightly by suffixing all prefixes by __ )
* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`
Either they're all prefixes, or we shall adjust all of the above to be something such as:
* `Umbraco__CMS__Global__Smtp__*`
* `Umbraco__Forms__Security__FormsApiKey__*`
* `Umbraco__Forms__FieldTypes__Recaptcha__*`
* `Umbraco__CMS__Integrations__*`
* `Umbraco__CMS__DeliveryAPI__*`
* `UMBRACO__LICENSES__*`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool! 💪
So anything can be added after the prefix? Is that correctly understood?
I could do something like UMBRACO__LICENSES__MyCoolUmbracoLicense ? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the way this is coded within the Umbraco Cloud platform, you can add any string behind these prefixes.
* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Let's keep that format then 💪
@jonat123 - you up for making the changes to the PR?
Description
It is possible to use UMBRACO__LICENSES__ for our addon products using the new license system.
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?