Skip to content

Conversation

@jonat123
Copy link
Contributor

@jonat123 jonat123 commented Nov 15, 2024

Description

It is possible to use UMBRACO__LICENSES__ for our addon products using the new license system.
What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@jonat123 jonat123 marked this pull request as ready for review November 15, 2024 09:27
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES__YOURPRODUCT`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `UMBRACO__LICENSES__YOURPRODUCT`
* `UMBRACO__LICENSES__`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pijemcolu wouldnt it be more clear to customers that they can add it for the different products with YOURPRODUCT at the end?

They might want to have more than one license in their projects.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do UMBRACO__LICENSES__XX as an alternative.
And then in a note below, we mention how to replace XX with the product name and give an example or two?

Copy link
Member

@pijemcolu pijemcolu Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a set of prefixes. This is a set of prefixes (Ok, we can improve slightly by suffixing all prefixes by __ )

* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`

Either they're all prefixes, or we shall adjust all of the above to be something such as:

* `Umbraco__CMS__Global__Smtp__*`
* `Umbraco__Forms__Security__FormsApiKey__*`
* `Umbraco__Forms__FieldTypes__Recaptcha__*`
* `Umbraco__CMS__Integrations__*`
* `Umbraco__CMS__DeliveryAPI__*`
* `UMBRACO__LICENSES__*`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool! 💪
So anything can be added after the prefix? Is that correctly understood?
I could do something like UMBRACO__LICENSES__MyCoolUmbracoLicense ? 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the way this is coded within the Umbraco Cloud platform, you can add any string behind these prefixes.

* `Umbraco__CMS__Global__Smtp__`
* `Umbraco__Forms__Security__FormsApiKey`
* `Umbraco__Forms__FieldTypes__Recaptcha`
* `Umbraco__CMS__Integrations`
* `Umbraco__CMS__DeliveryAPI`
* `UMBRACO__LICENSES`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Let's keep that format then 💪
@jonat123 - you up for making the changes to the PR?

@sofietoft sofietoft requested a review from pijemcolu November 19, 2024 08:48
@sofietoft sofietoft merged commit 91216d2 into umbraco:main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants