Skip to content

Conversation

@eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Nov 22, 2024

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

CMS v14 and v15

Deadline (if relevant)

Anytime

@eshanrnh eshanrnh marked this pull request as ready for review November 22, 2024 14:18
@sofietoft
Copy link
Contributor

Looks great 💪
Just one minor thing:
Alias is with a capital A for UI Alias but not for Schema alias 🙈
Not sure if it should be capital or not, but I think it should at least be consistent!

@eshanrnh
Copy link
Contributor Author

Good point, @sofietoft I've changed the Schema alias casing to be consistent with the UI alias casing 😀

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Looks great 😄

@eshanrnh eshanrnh merged commit 6fba34b into main Nov 28, 2024
45 of 63 checks passed
@eshanrnh eshanrnh deleted the ui-aliases branch November 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants