Skip to content

Conversation

@mattbrailsford
Copy link
Contributor

@mattbrailsford mattbrailsford commented Apr 1, 2025

Description

Umbraco Commerce Payment Links Guide

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco Commerce 15.3.0

Deadline (if relevant)

ASAP

@mattbrailsford
Copy link
Contributor Author

This PR includes a re-export of the swagger definition of the storefront API which is necessary to include the new endpoint added as part of this PR. It looks like a large change because we probably should have re-exported it during the v15 update but looks like we never did. However I have reviewed the preview site and all the storefront section looks to be how I would expect it so you can consider that reviewed by me.

@mattbrailsford mattbrailsford marked this pull request as ready for review April 29, 2025 12:43
@eshanrnh
Copy link
Contributor

eshanrnh commented May 2, 2025

Thanks for the PR, @mattbrailsford 💪We will review it as soon as we can.

@sofietoft
Copy link
Contributor

sofietoft commented May 5, 2025

Hi @mattbrailsford 👋

Apologies for the wait on this one.
I see there are quite a few warnings in the PR - mostly some long sentences.
Could you please take a look, and see if they can be rewritten to be shorter or split up? Thanks!

@mattbrailsford
Copy link
Contributor Author

Sorry, I've been on holiday the last 2 weeks, but these should all be updated now.

@sofietoft sofietoft merged commit f903dd1 into umbraco:main May 20, 2025
6 of 7 checks passed
@sofietoft
Copy link
Contributor

Apologies for the delay @mattbrailsford !
This has been merged now 💪

@mattbrailsford
Copy link
Contributor Author

No problem at all, thanks for reviewing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants