-
Notifications
You must be signed in to change notification settings - Fork 811
CMS: Adds new article on umbraco-extension
#7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new guide on using the umbraco-extension dotnet template to build Umbraco extensions, while also updating the Node.js version requirement and consolidating the TypeScript setup documentation into the main README.
- Added a detailed guide (umbraco-extension-template.md) for the Umbraco Extension Template.
- Updated Node.js version and related documentation to reflect LTS v22.15.0.
- Merged the TypeScript setup documentation from typescript-setup.md into README.md and added a corresponding redirect in .gitbook.yaml.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| 16/umbraco-cms/customizing/development-flow/vite-package-setup.md | Updated info block with a link to the new extension template guide. |
| 16/umbraco-cms/customizing/development-flow/umbraco-extension-template.md | New guide introducing the umbraco-extension dotnet template. |
| 16/umbraco-cms/customizing/development-flow/typescript-setup.md | Removed as its content was merged into README.md. |
| 16/umbraco-cms/customizing/development-flow/README.md | Merged TypeScript setup instructions and updated content and links. |
| 16/umbraco-cms/.gitbook.yaml | Added a redirect for the removed typescript-setup.md file. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thanks for the PR, @iOvergaard 💪 We will review it as soon as we can 🙌 |
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a technical perspective, I am happy with the changes.
I have left a couple of suggestions, no showstoppers.
16/umbraco-cms/customizing/development-flow/umbraco-extension-template.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/development-flow/umbraco-extension-template.md
Outdated
Show resolved
Hide resolved
…template.md Co-authored-by: Lee Kelleher <leekelleher@users.noreply.github.com>
…template.md Co-authored-by: Lee Kelleher <leekelleher@users.noreply.github.com>
eshanrnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @iOvergaard I've added couple of suggestions to reduce the usage of "You" and change sentences to active voice - which I'll incorporate in a moment.
Description
umbraco-extension-template.md, detailing how to use theumbraco-extensiondotnet template to create and manage Umbraco extensionsMinor Enhancements:
.gitbook.yamlto pointcustomizing/development-flow/typescript-setuptocustomizing/development-flow/README.md.vite-package-setup.mdguide to reference the newUmbraco Extension Templateas the recommended approach for building extensions.Type of suggestion
Product & version (if relevant)
16.0.0
Deadline (if relevant)
ASAP