Skip to content

Conversation

@hfloyd
Copy link
Contributor

@hfloyd hfloyd commented Sep 22, 2025

πŸ“‹ Description

πŸ“Ž Related Issues (if applicable)

Resolves #7410

βœ… Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (β€œwe”, β€œI”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

v13

Deadline (if relevant)

N/A

@hfloyd
Copy link
Contributor Author

hfloyd commented Sep 22, 2025

The linkchecker has failed, but these are the reasons (I think)

  • One of the links is an example (so not intended to be a real link)
  • One of the links requires login.

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this article, @hfloyd πŸ’ͺ It looks great.

I've added some suggestions following our styleguide, fixed vale, and broken link errors (added the example link in code tag).

Let me know if something doesn't make sense. If you like, I can also incorporate the comments myself.

hfloyd and others added 9 commits September 23, 2025 11:50
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@hfloyd
Copy link
Contributor Author

hfloyd commented Sep 23, 2025

Hi @eshanrnh ,
Those changes resolved most of the auto-checks, except there is still a link failure.

@eshanrnh
Copy link
Contributor

Thanks @hfloyd for incorporating the comments πŸ™Œ It looks like the link checker workflow is accidentally scanning the entire repo and reporting an error from a file outside this PR. No worries, I’ll take a look and fix it. πŸ’ͺ

@eshanrnh eshanrnh merged commit 92ec9c7 into umbraco:main Sep 24, 2025
19 of 20 checks passed
@hfloyd hfloyd deleted the feature/v13EntraUpdate branch September 24, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial Update needed (Add Microsoft Entra ID authentication (Members))

2 participants