Skip to content

Conversation

@NguyenThuyLan
Copy link
Contributor

📋 Description

I made a small edit in the section adding umbraco-package.json, because previously we suggested following the Vite Package Setup guide, so the guide talked about how to create the umbraco-package.json file and this file needs to be placed in the public folder, not the root folder.

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @NguyenThuyLan 🙌

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NguyenThuyLan On second thoughts, the file still needs to be created right, and then the code will be added to it?

Can you take a look at the suggestion and let me know if it makes sense?

…workspaces/workspace-views.md


Yes, it makes sense, thank @eshanrnh

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@eshanrnh eshanrnh merged commit 438d5ea into main Oct 17, 2025
48 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants