Skip to content

Conversation

@mattou07
Copy link
Contributor

@mattou07 mattou07 commented Mar 7, 2024

Description

What did you add/update/change?

The YAML snippet example refers to v3 of the upload and download github action task. v4 has significant performance improvements as mentioned in Githubs blog here: https://github.blog/2024-02-12-get-started-with-v4-of-github-actions-artifacts/

Type of suggestion

  • Updated outdated content

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

Anytime!

@alina-tincas
Copy link
Contributor

Hi @mattou07 thank you for the PR 🙌

We will take a look at it as soon as we can 🙏

@jonat123
Copy link
Contributor

jonat123 commented Mar 8, 2024

@mattou07 Makes sense to update it to the v4 😄

Should it be added to all versions of the example? 🤔

@mattou07
Copy link
Contributor Author

mattou07 commented Mar 8, 2024

@mattou07 Makes sense to update it to the v4 😄

Should it be added to all versions of the example? 🤔

Yes it should! Working on it

Copy link
Contributor

@jonat123 jonat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattou07 Looks good :-)

Merging it in :D

@jonat123 jonat123 merged commit 2b20d3f into umbraco:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants