Skip to content

Conversation

@alina-tincas
Copy link
Contributor

@alina-tincas alina-tincas commented Mar 21, 2024

Description

What did you add/update/change?
removing references to Macro and Partial view macro as they have been removed in v14: umbraco/Umbraco-CMS#15794

there are some exception though:

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

cms v14

Deadline (if relevant)

When should the content be published?
anytime

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alina-tincas, I've suggested two kinds of text. Based on if it is deprecated or no longer updated you can consider updating them 💪

_Checks to make sure macro errors are not set to throw a YSOD (yellow screen of death), which would prevent certain or all pages from loading completely._

{% hint style="warning" %}
Macros will be removed in the next version. Consider using Partial Views or blocks in Rich Text Editor.
Copy link
Contributor

@eshanrnh eshanrnh Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Macros will be removed in the next version. Consider using Partial Views or blocks in Rich Text Editor.
Macros will be removed in the next version. Consider using Partial Views or Blocks in Rich Text Editor.

alina-tincas and others added 3 commits March 22, 2024 09:09
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@alina-tincas
Copy link
Contributor Author

Thank you for the review @eshanrnh 🙌

I have chosen one suggestions and applied it to all of v13 hint notes 💪

Merging this in 😊

@alina-tincas alina-tincas merged commit 070befc into main Mar 22, 2024
@alina-tincas alina-tincas deleted the remove-macro-and-partial-view-macro branch March 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants