v14 replacing Newtonsoft.Json with IJsonSerializer #5996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-tincas
commented
Apr 2, 2024
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
alina-tincas
commented
Apr 2, 2024
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
alina-tincas
commented
Apr 2, 2024
...koffice/property-editors/built-in-umbraco-property-editors/block-editor/block-grid-editor.md
Outdated
Show resolved
Hide resolved
…in-umbraco-property-editors/block-editor/block-grid-editor.md
…in-umbraco-property-editors/block-editor/block-grid-editor.md
…in-umbraco-property-editors/block-editor/block-grid-editor.md
jonat123
approved these changes
Apr 3, 2024
Contributor
jonat123
left a comment
jonat123
left a comment
There was a problem hiding this comment.
@alina-tincas Looks good to me :-)
alina-tincas
commented
Apr 3, 2024
|
|
||
| Building Custom Views for Block representations in Backoffice is the same for all Block Editors. [Read about building a Custom View for Blocks here](build-custom-view-for-blocks.md) | ||
|
|
||
| ## Creating BlockList programmatically |
Contributor
Author
There was a problem hiding this comment.
removing this as the example does not make much sense and it also follows a bad practice of using a view instead of a class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
from v14 Newtonsoft.Json has been replaced with IJsonSerializer so I have updated the code examples to match with with this new update
will make another task internally to update the code examples from views to classes due to best practice
-
have not tested the code changes, just updated the codeType of suggestion
Product & version (if relevant)
cms v14
Deadline (if relevant)
When should the content be published?