Rewrite "Creating a user" as "Managing users" #6177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kjac Thanks for creating this PR 😄 We will review it as soon as we can 😊 |
jonat123
reviewed
Jun 17, 2024
jonat123
reviewed
Jun 17, 2024
jonat123
requested changes
Jun 17, 2024
Contributor
jonat123
left a comment
jonat123
left a comment
There was a problem hiding this comment.
@kjac Looks good!
Just have two suggestions 😄
SInce you are removing an article, we also need a redirect in place.
Can you add the following line to the .gitbook.yaml file:
reference/management/services/create-a-new-user: reference/management/services/managing-users.md
you can find the file in the 14 -> umbraco-cms folder 😄
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Contributor
Author
|
Done @jonat123 👍 |
# Conflicts: # 14/umbraco-cms/.gitbook.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Creating a user" article references obsolete and removed classes and service methods. It is also not at all about creating users - it is about adding users to groups 😆
I have rewritten the entire article to get the code samples etc. up to date with V14. I have also opted to rename the article to "Managing Users". Eventually we could add more samples to this - for example, something about creating users? 😛
Type of suggestion
Product & version (if relevant)
V14
Deadline (if relevant)
Whenever possible.