add full character substitution details #6186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofietoft
requested changes
Jun 11, 2024
Contributor
sofietoft
left a comment
sofietoft
left a comment
There was a problem hiding this comment.
Thanks for the PR @jmf-umbraco ! 💪
I've added a suggestion - let me know what you think!
sofietoft
approved these changes
Jun 11, 2024
Contributor
sofietoft
left a comment
sofietoft
left a comment
There was a problem hiding this comment.
Excellent @jmf-umbraco !
And this can go live whenever, right? 🤞
Contributor
Author
|
Sure can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed table of character substitutions in Heartcore migration to remove entries that aren't changing and provide a comprehensive list of ones that are.
Type of suggestion
Product & version (if relevant)
Heartcore
Deadline (if relevant)
N / A