-
Notifications
You must be signed in to change notification settings - Fork 810
Missing information in Workflow #6224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @eshanrnh ! 💪
I've added a review - take a look, and let me know what you think.
I'm probably mostly knit-picking, but I was inspired and got a bit carried away 😅
Co-authored-by: sofietoft <stk@umbraco.com>
|
Thanks for your review, @sofietoft 🙌 I've incorporated your comments. Let me know what you think 😀 |
|
I noticed a couple of broken links in both "Content Apps" and the "Submitting changes" article when previewing on GitBook. Update: Looks like the links work when viewing the articles here on GitHub 🤷 |
nathanwoulfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eshanrnh this looks great - thanks for restoring the content app page too. I will have some changes for that one specific to v14, but I'll handle those separate to this PR (along with any other release-related changes for 14).
Description
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?