Skip to content

Conversation

@eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Jun 28, 2024

Description

  • Rearranged article in summary file as per the workflow process.
  • Improved descriptions of certain fields and added Notes where required.
  • Updated outdated images.
  • Added missing info about publish/unpublish setting in both v13 and v14.
  • Content App article is misisng in v14. Figuring out if its just a glitch while the articles were moved over. Will update for v14 accordingly.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@eshanrnh eshanrnh added review/developer Use this label if an internal developer review is required review/docsteam labels Jul 1, 2024
@eshanrnh eshanrnh marked this pull request as ready for review July 1, 2024 10:16
@eshanrnh eshanrnh requested a review from nathanwoulfe July 1, 2024 10:17
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @eshanrnh ! 💪

I've added a review - take a look, and let me know what you think.
I'm probably mostly knit-picking, but I was inspired and got a bit carried away 😅

@eshanrnh
Copy link
Contributor Author

eshanrnh commented Jul 2, 2024

Thanks for your review, @sofietoft 🙌 I've incorporated your comments. Let me know what you think 😀

@sofietoft
Copy link
Contributor

sofietoft commented Jul 2, 2024

I noticed a couple of broken links in both "Content Apps" and the "Submitting changes" article when previewing on GitBook.
Not sure if they're actually broken, or if it's just an issue with the preview 🤔

Update: Looks like the links work when viewing the articles here on GitHub 🤷

Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eshanrnh this looks great - thanks for restoring the content app page too. I will have some changes for that one specific to v14, but I'll handle those separate to this PR (along with any other release-related changes for 14).

@eshanrnh eshanrnh merged commit f131078 into main Jul 3, 2024
@eshanrnh eshanrnh deleted the Workflow-settings branch July 5, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/umbraco-workflow review/developer Use this label if an internal developer review is required review/docsteam

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants