Skip to content
This repository was archived by the owner on Jun 18, 2018. It is now read-only.

Conversation

@Jeavon
Copy link

@Jeavon Jeavon commented Aug 25, 2015

Often when updating Umbraco NuGet packages that contain App_Plugin content we have excluded the folder from our solution so the files don't get upgraded. This install.ps1 copies the "App_Plugins/NestedContent" folder to the correct path if it's been excluded from the VS project since original installation, it it hasn't it been excluded, it does nothing

… the project if it's been excluded from the project since original installation
@mattbrailsford
Copy link
Collaborator

mattbrailsford commented Aug 25, 2015 via email

@Jeavon
Copy link
Author

Jeavon commented Aug 25, 2015

Haven't tested but I'm pretty sure it will do nothing as there is no concept of excluding folders or files so the folders will be there. I don't think I've ever installed a NuGet package in a website project, I'll give it a try and see what happens

@mattbrailsford
Copy link
Collaborator

my fear is the use of $project.FullName will cause an error as I think its a URL in a website project.

@Jeavon
Copy link
Author

Jeavon commented Aug 26, 2015

You were right, I have added a earlier check for the App_Plugins/NestContent folder so it works fine now. Really interesting how NuGet works with Website projects, I've never tried it before :)

@mattbrailsford
Copy link
Collaborator

Tell me about it, I've been trying to get core to support them for months. Created a PR to make it work and everything umbraco/Umbraco-CMS#738

@leekelleher
Copy link
Collaborator

Picking up on this. I'm cool with having this merged in. @mattbrailsford do you have any concerns? (re: Website projects)

@Jeavon - cosmetic question, does the "Install.ps1" file need to be capitalised? Can it be lowercase? (I can do that post-merge if so)

@leekelleher leekelleher added this to the 0.3.0 milestone Oct 2, 2015
@Jeavon
Copy link
Author

Jeavon commented Oct 2, 2015

@leekelleher
Copy link
Collaborator

@Jeavon No worries, it's just me being pedantic 😝

@Jeavon
Copy link
Author

Jeavon commented Oct 2, 2015

@leekelleher it's interesting, I'm always confused, MS guidelines would have it capitalised wouldn't they...?

@leekelleher
Copy link
Collaborator

@Jeavon Yeah, that NuGet doc mentions "Install.ps1", then in the detail it goes lowercase...

If your package also has an init.ps1, install.ps1 runs after init.ps1.

I think it's fine either way.

@Jeavon
Copy link
Author

Jeavon commented Oct 2, 2015

@leekelleher hmmm, if they mix it up there then I guess it doesn't matter...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants