-
Notifications
You must be signed in to change notification settings - Fork 33
Add install.ps1 #28
Add install.ps1 #28
Conversation
… the project if it's been excluded from the project since original installation
|
What does this do when installed in a website project? Has this scenario
been tested?
|
|
Haven't tested but I'm pretty sure it will do nothing as there is no concept of excluding folders or files so the folders will be there. I don't think I've ever installed a NuGet package in a website project, I'll give it a try and see what happens |
|
my fear is the use of $project.FullName will cause an error as I think its a URL in a website project. |
|
You were right, I have added a earlier check for the App_Plugins/NestContent folder so it works fine now. Really interesting how NuGet works with Website projects, I've never tried it before :) |
|
Tell me about it, I've been trying to get core to support them for months. Created a PR to make it work and everything umbraco/Umbraco-CMS#738 |
|
Picking up on this. I'm cool with having this merged in. @mattbrailsford do you have any concerns? (re: Website projects) @Jeavon - cosmetic question, does the "Install.ps1" file need to be capitalised? Can it be lowercase? (I can do that post-merge if so) |
|
@leekelleher I don't know if it has to be capitalised, but the NuGet docs always have it that way e.g. https://docs.nuget.org/create/creating-and-publishing-a-package#user-content-automatically-running-powershell-scripts-during-package-installation-and-removal |
|
@Jeavon No worries, it's just me being pedantic 😝 |
|
@leekelleher it's interesting, I'm always confused, MS guidelines would have it capitalised wouldn't they...? |
|
@Jeavon Yeah, that NuGet doc mentions "Install.ps1", then in the detail it goes lowercase...
I think it's fine either way. |
|
@leekelleher hmmm, if they mix it up there then I guess it doesn't matter... |
Often when updating Umbraco NuGet packages that contain App_Plugin content we have excluded the folder from our solution so the files don't get upgraded. This install.ps1 copies the "App_Plugins/NestedContent" folder to the correct path if it's been excluded from the VS project since original installation, it it hasn't it been excluded, it does nothing