This repository was archived by the owner on Jun 18, 2018. It is now read-only.
Adds localized titles to anchors surrounding icons. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2015 16:10
leekelleher
changed the title
Collaborator
|
@rustyswayne Thanks for this PR. Sorry it's taken a while to reply. I'm happy with the addition. @mattbrailsford Any comments? On a side-note, we will need to revert the amends to the ".gitignore" and "VersionInfo.cs" files. |
Collaborator
There was a problem hiding this comment.
This will need to be reverted, as we use StyleCop on the project.
Collaborator
|
Merged in commit c60b9bc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, Not sure if you want this, but in Merchello I've now "borrowed" your icon styles in an attempts to keep unified with the back office and with some of the great property editors (like NC) out there.
In Merchello, I needed to add a few more that were not as obvious as edit, move and delete so I added localized titles to the anchor surrounding the icon (i). I've updated my fork of Nested Content to include these for you to evaluate and decide whether or not you think it's a good idea.