Skip to content
This repository was archived by the owner on Jun 18, 2018. It is now read-only.

Conversation

@rasmusjp
Copy link

Hey, I've looked at the validation and I've found a way to call the validators for each property.
Mandatory and regex validation is still needed tho.

I've only tested this on a small subset of property editors but it seems to do the validation correct.

@mattbrailsford
Copy link
Collaborator

Interesting. Looks like a nice fix. I'm away for a week now though so will have to take a look on my return unless @leekelleher fancies testing it?

@mattbrailsford
Copy link
Collaborator

One initial comment just looking at it, I'd be tempted to alter the validation message that is returned to prefix like the mandatory / regex ones do, telling you which item in the nested content has the problem, this way it's easier to find the issue.

mattbrailsford added a commit that referenced this pull request Nov 28, 2015
Added nested property editor validation support
@mattbrailsford mattbrailsford merged commit d9112cf into umco:develop Nov 28, 2015
@mattbrailsford mattbrailsford added this to the 0.3.0 milestone Nov 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants