Skip to content
This repository was archived by the owner on Jun 18, 2018. It is now read-only.

Conversation

@ProNotion
Copy link

This fixes Issue #38 whereby recursive property lookups were not working as expected when a property with a previous nested content property editor previously had a value which was later removed. See the forum post.

…ction therefore not breaking recursive property lookups
@leekelleher
Copy link
Collaborator

Cool, thanks @ProNotion!

Before I merge it in, just want to ping @mattbrailsford for a sanity check ... Matt, do you see any issue with this?

@leekelleher leekelleher self-assigned this Nov 10, 2015
@leekelleher leekelleher added this to the 0.3.0 milestone Nov 10, 2015
@mattbrailsford
Copy link
Collaborator

My only concern is with it now returning null rather string.empty, and did we use string.empty for a reason?

@leekelleher
Copy link
Collaborator

I had the same thought, but then noticed that an earlier line returned null.

@ProNotion
Copy link
Author

I noticed the same as Lee and changed it for consistency. Returning string.Empty I think did appear to have the same end result.

@mattbrailsford
Copy link
Collaborator

all good then

leekelleher added a commit that referenced this pull request Nov 13, 2015
Fixes Issue #38 Returns null if there are no objects in the collection
@leekelleher leekelleher merged commit 30923c2 into umco:develop Nov 13, 2015
@leekelleher
Copy link
Collaborator

Merged, thanks @ProNotion!

@jessetinell
Copy link

jessetinell commented Jun 29, 2016

I just stumbled upon this issue aswell (#38).
Is 0.3.0 planned to be released or is this project on hold? Almost a year since previous release.

@ProNotion ProNotion deleted the issues/38 branch June 29, 2016 09:07
@ProNotion ProNotion restored the issues/38 branch June 29, 2016 09:07
@leekelleher
Copy link
Collaborator

@jessetinell There are various excuses and delays with us releasing v0.3.0 - mainly that we've been focusing on getting it into the Umbraco core product. (Due in v7.6)

In the meantime, the latest development build of NC can be downloaded from here:
https://ci.appveyor.com/project/leekelleher/umbraco-nested-content/build/artifacts

We also have a MyGet feed if you wanted to use the NuGet package:
https://www.myget.org/feed/umbraco-packages/package/nuget/Our.Umbraco.NestedContent

We're still planning on releasing NC v0.3.0, it's just a matter of us finding the free time to prepare and test it.

@jessetinell
Copy link

jessetinell commented Jun 29, 2016

@leekelleher Ok great, thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

4 participants