Centralize CAN Interface#123
Merged
IshanDutta11 merged 3 commits intoMay 13, 2026
Merged
Conversation
IshanDutta11
force-pushed
the
centralize-can-interface
branch
from
a7ad063 to
714ebfa
Compare
Collaborator
|
Looks good, can we default everything to CAN1 and then test this on the rover? then would approve and merge. |
Contributor
Author
|
ok i added the can interface argument and had can1 as the default for the mission launch files. Tried it out and they seem to work (obviously won't completely launch but I can see that they attempt to bring up can1). If theres anything else lmk |
mdurrani808
approved these changes
May 13, 2026
ethanhchoi
pushed a commit
to ethanhchoi/athena-code
that referenced
this pull request
May 19, 2026
* can interface can now be easily swapped without having to rewrite it in each file * mission tasks default to can1 --------- Co-authored-by: duttaishan01 <duttaishan01@FIGARO.myguest.virtualbox.org> Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can interface can now be modified from a simple launch argument.
For example:
ros2 launch arm_bringup athena_arm.launch.py can_interface:=can1