Skip to content

Conversation

@xiaohuoni
Copy link
Member

Close: umijs/umi#4483

支持旧的写法

{
        path: '/',
        component: '@/pages/index',
        menu: { // 兼容此写法
            name: '欢迎',
            icon: 'smile',
        }
}

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #168 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   51.60%   51.53%   -0.08%     
==========================================
  Files          63       63              
  Lines        1430     1432       +2     
  Branches      401      419      +18     
==========================================
  Hits          738      738              
- Misses        692      694       +2     
Impacted Files Coverage Δ
packages/plugin-layout/src/index.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fde8e...2ca6f4f. Read the comment docs.

@sorrycc
Copy link
Member

sorrycc commented Apr 20, 2020

老的迁移下?

@xiaohuoni
Copy link
Member Author

老的迁移下?

这有点不好说。预计 issues 会比较多。给说明的话,可以考虑关闭。现在的 menu 配置,都是有效的,只是这个 icon 没被转化。如果要不兼容旧的写法,那要考虑全部删除 menu 配置,不然支持 menu 配置,只是不支持 menu 配置 icon 。感觉不太合理。

@xiaohuoni xiaohuoni requested a review from chenshuai2144 April 26, 2020 01:53
@chenshuai2144 chenshuai2144 merged commit 16c1d93 into master Jun 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the support-menu-configuration-Icon branch June 26, 2020 07:34
@chenshuai2144
Copy link
Contributor

menu:{} 这个配置是应该兼容一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

使用@umijs/umi-app创建的项目Icon不显示,控制台出现warning

5 participants