fix: 修复 layout 配置 menu 显示指定为 false 不生效 #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete-merged-branch
bot
deleted the
fix/menu-set-false-does-not-take-effect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前为了兼容老得写法，所以配置了 name 就等同于配置了 menu，优先级高于 menu：false。
然后存在 menu 为 false 时，name 仍用于 document.title 等用途的场景，所以调高优先级，menu 显示指定为 false 时，不在侧边栏中展示，与文档保持一致。
Close umijs/umi#4179