Replies: 4 comments
|
thx for the detailed write-up. this is already achievable with existing configuration, without changes to ralphex core. for Claude phases (tasks, reviews, plan creation, finalize) - for external review phase - already supports for per-phase configuration - the combination of these three covers the use cases described. adding provider-specific adapters to core was considered and rejected in #59 - maintaining parsing, streaming, signal detection, and error handling per provider creates a support burden that doesn't justify the convenience gain over wrapper scripts. pls use discussions for pitches/ideas like this, issues are for bugs and actionable feature requests. |
|
Thanks, P.S. I did not know discussions feature is a thing in GitHub, so yeah, I would use it next time. |
|
Follow-up on this — added a working codex wrapper script and documentation in #133. What's included:
Config to use it: claude_command = /path/to/scripts/codex-as-claude.sh
claude_args =Environment variables: Tested end-to-end — tasks, all review phases, and finalize completed successfully. The wrapper filters out command execution noise by default (codex reads many files on startup), only passing through agent messages. The custom-providers doc also includes minimal templates for writing wrappers for other tools, so this should cover the use case without needing core routing changes. |
|
I tried this approach. It works good enough for my use case. I managed to write my own adapter before you added yours. Guide helped me to finalize it. One note though: I find {"type":"item.completed","item":{"id":"item_0","type":"reasoning","text":"**Preparing git log summary**"}}
{"type":"item.completed","item":{"id":"item_1","type":"agent_message","text":"I’ll inspect the last 3 commits and summarize what changed in each one using their messages and diff stats."}}
{"type":"item.completed","item":{"id":"item_10","type":"reasoning","text":"**Checking commit message details**"}}
{"type":"item.completed","item":{"id":"item_11","type":"agent_message","text":"I pulled the added/removed test names; next I’ll check commit metadata to capture any explicit rationale from the commit messages."}}Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I know ralphex is intentionally Claude-first and opinionated tool. And I’m not proposing to change that philosophy or default behavior. This is a proposal to make provider choice more flexible per phase, while keeping Claude as the default primary path. If this direction makes sense to you, I’m ready to invest more time polishing it for production quality; if not, I can keep it as a local customization or a public fork (if you allow it). I already have an initial working prototype (which shows that this works without any regression) and wanted to check whether this is worth pushing further upstream.
Why I think this is worth considering now:
--jsonflag.Architecture overview of what’s already implemented:
If you’re open to it, I can continue with cleanup/polish work and narrow it to whatever scope you’d be comfortable merging. Otherwise I would keep it separate.
All reactions