feat(launch): pass REVDIFF_CONFIG to overlay and add configurable popup size#17
Merged
umputun merged 2 commits intoumputun:masterfrom Apr 5, 2026
Merged
Conversation
…up size Two improvements to the launch script: 1. Pass REVDIFF_CONFIG env var as --config flag to revdiff inside tmux popups. The sh -c invocation doesn't inherit fish universal variables, so the config path was lost in overlay shells. 2. Add REVDIFF_POPUP_WIDTH and REVDIFF_POPUP_HEIGHT env vars to override the default 90% tmux popup dimensions.
umputun
reviewed
Apr 5, 2026
Owner
umputun
left a comment
umputun
left a comment
There was a problem hiding this comment.
thx for the PR, makes sense - fish universal vars not propagating through sh -c is a real issue.
couple things:
REVDIFF_POPUP_WIDTH/REVDIFF_POPUP_HEIGHTonly affect tmux - wezterm path still has hardcoded--percent 90. not a blocker but worth noting for consistency- new env vars (
REVDIFF_POPUP_WIDTH,REVDIFF_POPUP_HEIGHT) aren't documented anywhere - would be good to add them to the reference docs or README
otherwise LGTM, clean and minimal
There was a problem hiding this comment.
Pull request overview
This PR ensures revdiff’s config path is preserved when launching inside tmux popups (where sh -c won’t see fish universal vars) and adds env-var overrides for tmux popup dimensions.
Changes:
- Inject
REVDIFF_CONFIGinto overlay-launched revdiff runs via a computed--config=...flag. - Add
REVDIFF_POPUP_WIDTH/REVDIFF_POPUP_HEIGHTto override tmux popup-w/-hdefaults.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
addressed both points in 65020ff:
|
umputun
approved these changes
Apr 5, 2026
Owner
umputun
left a comment
umputun
left a comment
There was a problem hiding this comment.
LGTM, thx for addressing both points. clean and well-scoped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REVDIFF_CONFIGenv var as--configflag to revdiff inside tmux popups. Thesh -cinvocation doesn't inherit fish universal variables, so the config path was lost in overlay shells.REVDIFF_POPUP_WIDTHandREVDIFF_POPUP_HEIGHTenv vars to override the default 90% tmux popup dimensions.