improve: scale annot_list popup width up to 140 cols on wide terminals#195
Merged
Conversation
#191) Bump the upper cap on the popup width from 70 to 140 so the annotation list uses available screen real estate on wide terminals. Comments get 2x more room before truncation; terminals under 80 cols are unchanged.
There was a problem hiding this comment.
Pull request overview
This PR increases the annotation list overlay width cap so annot_list can use more horizontal space on wide terminals, improving readability without changing narrow-terminal behavior.
Changes:
- Raises annotation list popup width cap from 70 to 140 columns.
- Adds a regression test covering popup width scaling across narrow, medium, capped, and wide terminal sizes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/ui/overlay/annotlist.go |
Updates the annotation list popup width calculation to allow wider rendering. |
app/ui/overlay/annotlist_test.go |
Adds coverage for the new width scaling behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- [style] [annotlist.go:32] extract annotPopupMaxWidth/MinWidth/Margin/BorderPad constants matching themeselect.go and info.go - [style] [annotlist_test.go:87] derive wantW from wantPopup + borderCols so the +2 border math is explicit per case - [minor] [annotlist_test.go] add TestAnnotListOverlay_RenderWidePopupFitsMoreCommentText covering the user-visible payoff (more comment chars before truncation on wide terminals), not just popup geometry
Deploying revdiff with
|
| Latest commit: |
366d725
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3640f366.revdiff.pages.dev |
| Branch Preview URL: | https://widen-annot-list-popup.revdiff.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the annotation list popup's upper width cap from 70 to 140 cols (
app/ui/overlay/annotlist.go:32) so it uses available screen real estate on wide terminals. Comment text gets ~2x more room before truncation; terminals under 80 cols are unchanged.The 2-line layout proposed in the issue is not included: it halves visible-entry density which matters for users with many annotations. The width bump alone addresses the core "wasted screen space" complaint.
Addresses #191