No Changeset found comment should only appears once

[devtribe]

If there is a commit in a branch with open Merge Request and a "No Changeset found" comment is already there, the application should not add another one. It quickly gets confusing with all the other comments.

[JounQin]

Any screenshot? Or reproduction?

[devtribe]

Sorry for forgetting the context.

This is my gitlab ci job:

comment:
  stage: comment
  extends:
    - .init-pnpm
  rules:
    - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_COMMIT_BRANCH != "changeset-release/main"'
  script:
    - pnpm changesets-gitlab comment # comment automatically like https://github.com/changesets/bot

.init-pnpm:
  before_script:
    - yarn global add pnpm
    - pnpm config set store-dir .pnpm-store
    - pnpm install
  cache:
    key:
      files:
        - pnpm-lock.yaml
    paths:
      - .pnpm-store

and here are the used versions:

    "@changesets/cli": "^2.24.1",
    "changesets-gitlab": "^0.5.5",

And here is a screenshot.

Thanks!

[JounQin]

@devtribe

That's weird, did you config GITLAB_CI_USER_NAME?

changesets-gitlab/src/comment.ts

Lines 110 to 116 in 27af288

	const changesetBotNote = discussion.notes.find(
	note =>
	note.author.username === process.env.GITLAB_CI_USER_NAME &&
	// We need to ensure the note is generated by us but we don't have a app bot like GitHub
	// @see https://github.com/apps/changeset-bot
	note.body.includes('Generated By Changesets GitLab Bot'),
	)

[JounQin]

You use ds300/patch-package and modify node_modules/changeset-gitlab to debug on your CI.

[devtribe]

That's it. The GITLAB_CI_USER_NAME differs from the one the token belongs to.

Maybe it's possible to get the user name from the api. This should return the username from the current authetificated user https://docs.gitlab.com/ee/api/users.html#list-current-user

GET /user

{
  "id": 1,
  "username": "john_smith",
}

So there will be fewer configuration errors.

[JounQin]

Maybe it's possible to get the user name from the api.

Good idea! Are you willing to raise a PR for it?

[Inoir]

sadly this is closed?!
Should be still done. ive same issue and this get call would help alot to avoid this issue