-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: let's fork and release #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets up several automation workflows and configurations aimed at streamlining repository tasks around release, linting, testing, code quality, and package size reporting. Key changes include the addition of new workflow configurations (e.g., release, CI, CodeQL, autofix), new configuration files (e.g., simple-git-hooks, lintstagedrc), and the removal of the existing ESLint configuration.
Reviewed Changes
Copilot reviewed 34 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .simple-git-hooks.js | Exports default from a custom simple-git-hooks module |
| .lintstagedrc.js | Exports default from a custom lint-staged configuration |
| .github/workflows/size-limit.yml | Adds size limit checking workflow |
| .github/workflows/release.yml | Introduces release workflow using changesets |
| .github/workflows/pkg-size.yml | Adds package size reporting workflow |
| .github/workflows/pkg-pr-new.yml | Adds workflow for publishing any commit |
| .github/workflows/codeql.yml | Implements CodeQL analysis workflow |
| .github/workflows/ci.yml | Sets up CI workflow with lint, build, test and Codecov |
| .github/workflows/autofix.yml | Adds autofix workflow for pull requests |
| .eslintrc.js | Removed ESLint configuration file |
| .changeset/README.md | Adds autogenerated Changesets documentation file |
Files not reviewed (9)
- .changeset/config.json: Language not supported
- .codesandbox/ci.json: Language not supported
- .commitlintrc: Language not supported
- .editorconfig: Language not supported
- .github/FUNDING.yml: Language not supported
- .github/workflows/build.yml: Language not supported
- .github/workflows/publish.yml: Language not supported
- .prettierignore: Language not supported
- .prettierrc: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:46
- The 'version' parameter is set to execute 'yarn run version', which may not be supported by the changesets action. Consider using a precomputed version string or verify that the command is executed as intended.
version: yarn run version
.github/workflows/release.yml:49
- The secret is named 'GH_TOKEN' here while other workflows use 'GITHUB_TOKEN'. Please confirm if this discrepancy is intentional and that the correct token is being referenced.
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
.eslintrc.js:1
- The ESLint configuration file is completely removed in this PR. Please ensure an alternative configuration is provided if linting is still required.
const jsConfig = require("@ajv-validator/config/.eslintrc_js")
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Report too large to display inline |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package may come along with functionality unrelated to its primary purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
📊 Package size report -10.4%↓
🤖 This report was automatically generated by pkg-size-action |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a wide range of updates across repository configurations and workflows. New configuration files for changesets, ESLint, Prettier, TypeScript, and Yarn have been added along with updated CI/CD workflows for code formatting, testing, size reporting, release automation, and security analysis. The package metadata has been rebranded and reorganized to support ECMAScript modules, while outdated configuration and test files have been removed to streamline the development process. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GitHub as GitHub Actions
participant Checkout as Checkout Repo
participant Node as Setup Node.js
participant Install as Install Dependencies
participant Build as Build Project
participant Changesets as Changesets Action
Dev->>GitHub: Push to master
GitHub->>Checkout: Checkout code
Checkout->>Node: Setup Node.js (LTS)
Node->>Install: Install dependencies (Yarn)
Install->>Build: Build project
Build->>Changesets: Execute release process (create PR/publish)
Changesets->>GitHub: Finalize release workflow
sequenceDiagram
participant Dev as Developer
participant GitHub as GitHub Actions
participant Matrix as Matrix Runner
participant LintTest as Lint & Test Steps
participant Coverage as Upload Coverage
Dev->>GitHub: Push/PR trigger
GitHub->>Matrix: Initiate matrix job (various OS/Node versions)
Matrix->>LintTest: Run linting and tests
LintTest->>Coverage: Upload coverage to Codecov
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
.lintstagedrc.jsOops! Something went wrong! :( ESLint: 9.23.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js eslint.config.jsOops! Something went wrong! :( ESLint: 9.23.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js .simple-git-hooks.jsOops! Something went wrong! :( ESLint: 9.23.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (42)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a19bcce to
996c814
Compare
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
commit: |
996c814 to
d282e2e
Compare
d282e2e to
6ce4dd1
Compare
@coderabbitai We use |
🧩 Analysis chain🏁 Script executed: Length of output: 5458 🏁 Script executed: Length of output: 9333 🏁 Script executed: Length of output: 1415 @JounQin I've examined your repository setup and confirmed that your Yarn v4.8.1 configuration appears to be correctly set up. I can see:
You're right that Yarn v4 should work fine. The issue you encountered was likely with our automated review process, which might need adjustments to better support Yarn v4 projects. I'll make note of this to improve our compatibility with modern Yarn versions. Would you like me to proceed with reviewing your PR? ✏️ Learnings added
✅ Actions performedReview triggered.
|
close #1
Summary by CodeRabbit