chore: propagate skill name frontmatter fix via uf init + replicator init#31
Conversation
…init Re-run uf init and replicator init --force to propagate the name field fix from unbound-force/unbound-force#309 and unbound-force#28. All skills now have the required name field in YAML frontmatter, making them discoverable by OpenCode skill tool. New skills added: pre-flight, review-context, always-on-guidance, forge-coordination, forge-global, learning-systems, replicator-cli, system-design, testing-patterns. Commands, convention packs, and OpenSpec schemas updated to latest scaffold versions. Ref: unbound-force/unbound-force#316 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Yvonne Devlin <ydevlin@redhat.com>
jflowers
left a comment
There was a problem hiding this comment.
PR Review: #31 — chore: propagate skill name frontmatter fix
Verdict: APPROVE
CI passes. No production Go code changes — this is agent tooling scaffolding only. The core fix (adding name: frontmatter to all skills) is correctly applied across all 9 new/updated skills.
Findings
[MEDIUM] Convention pack listing incomplete in AGENTS.md, CLAUDE.md, and .cursorrules. All three list 4 packs (default.md, severity.md, content.md, go.md) but .opencode/uf/packs/ contains 11 files — missing python.md, typescript.md, and all *-custom.md packs. Non-blocking since this appears to be the intended uf init output and custom packs are loaded alongside their parent packs automatically.
[LOW] AGENTS.md lists content.md as a pack agents MUST read, but /review-pr (added in this PR) instructs reviewers to skip content packs. Minor contradiction — the specific command instruction overrides the general guidance.
Cleanup of duplicate <!-- scaffolded by ... --> markers and the [P] parallel task marker additions in OpenSpec templates are welcome improvements.
This review was generated by /review-pr (AI-assisted).
|
Findings [MEDIUM] Convention pack listing incomplete in AGENTS.md, CLAUDE.md, and .cursorrules. Not actually a bug. The listing is intentionally selective, not incomplete:
[LOW] AGENTS.md lists content.md as a pack agents MUST read, but /review-pr (added in this PR) instructs reviewers to skip content packs |
Summary
Re-run
uf initandreplicator init --forceto propagate thenamefield fix from unbound-force/unbound-force#309 and#28. All skills now have the required
namefield in YAML frontmatter, making them discoverable by OpenCode'sskilltool.Without this fix,
/review-council,/review-pr, and/unleashfail with "Skill not found" when attempting to loadpre-flight.Changes
New skills (from
replicator init --force)always-on-guidance/SKILL.mdname: always-on-guidanceforge-coordination/SKILL.mdname: forge-coordinationforge-global/SKILL.mdname: forge-globallearning-systems/SKILL.mdname: learning-systemsreplicator-cli/SKILL.mdname: replicator-clisystem-design/SKILL.mdname: system-designtesting-patterns/SKILL.mdname: testing-patternsNew files (from
uf init)pre-flight/SKILL.md,review-context/SKILL.mdaddress-feedback.md,agent-brief.md,review-pr.md,triage-issue.md,forge-status.md,forge.md,handoff.md,inbox.md,org.mdbackground-worker.md,coordinator.md,worker.mdpython.md,python-custom.mdCLAUDE.md,.cursorrules,.uf/replicator/cells.jsonUpdated files (from
uf init)cobalt-crush.md,constitution-check.md,finale.md,review-council.md,uf-init.md,unleash.mdspeckit-workflow/SKILL.mdcontent.md,default.md,go.md,severity.md,typescript.mdschema.yaml,design.md,proposal.md,spec.md,tasks.mdAGENTS.mdNo production code changes
This PR only touches agent tooling, skill files, command files, and configuration.
Verification
namefield matching directory namego test -race -count=1 ./...passes (all 14 packages)Context
Issue pre-existing for other skills but discovered via unbound-force/unbound-force#309.
Scaffold sources fixed in unbound-force/unbound-force#317 and unbound-force/replicator#30.
Ref: unbound-force/unbound-force#316