Skip to content

chore: propagate skill name frontmatter fix via uf init + replicator init#31

Merged
yvonnedevlinrh merged 1 commit into
unbound-force:mainfrom
yvonnedevlinrh:chore/skill-name-propagation
Jul 2, 2026
Merged

chore: propagate skill name frontmatter fix via uf init + replicator init#31
yvonnedevlinrh merged 1 commit into
unbound-force:mainfrom
yvonnedevlinrh:chore/skill-name-propagation

Conversation

@yvonnedevlinrh

@yvonnedevlinrh yvonnedevlinrh commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Re-run uf init and replicator init --force to propagate the name field fix from unbound-force/unbound-force#309 and
#28. All skills now have the required name field in YAML frontmatter, making them discoverable by OpenCode's skill tool.

Without this fix, /review-council, /review-pr, and /unleash fail with "Skill not found" when attempting to load pre-flight.

Changes

New skills (from replicator init --force)

Skill Added field
always-on-guidance/SKILL.md name: always-on-guidance
forge-coordination/SKILL.md name: forge-coordination
forge-global/SKILL.md name: forge-global
learning-systems/SKILL.md name: learning-systems
replicator-cli/SKILL.md name: replicator-cli
system-design/SKILL.md name: system-design
testing-patterns/SKILL.md name: testing-patterns

New files (from uf init)

  • Skills: pre-flight/SKILL.md, review-context/SKILL.md
  • Commands: address-feedback.md, agent-brief.md, review-pr.md, triage-issue.md, forge-status.md, forge.md, handoff.md, inbox.md, org.md
  • Agents: background-worker.md, coordinator.md, worker.md
  • Convention packs: python.md, python-custom.md
  • CLAUDE.md, .cursorrules, .uf/replicator/cells.json

Updated files (from uf init)

  • Commands: cobalt-crush.md, constitution-check.md, finale.md, review-council.md, uf-init.md, unleash.md
  • Skills: speckit-workflow/SKILL.md
  • Convention packs: content.md, default.md, go.md, severity.md, typescript.md
  • OpenSpec schemas: schema.yaml, design.md, proposal.md, spec.md, tasks.md
  • AGENTS.md

No production code changes

This PR only touches agent tooling, skill files, command files, and configuration.

Verification

  • All 14 skills have name field matching directory name
  • go test -race -count=1 ./... passes (all 14 packages)

Context

Issue pre-existing for other skills but discovered via unbound-force/unbound-force#309.
Scaffold sources fixed in unbound-force/unbound-force#317 and unbound-force/replicator#30.

Ref: unbound-force/unbound-force#316

…init

Re-run uf init and replicator init --force to propagate the name
field fix from unbound-force/unbound-force#309 and
unbound-force#28. All skills now have the required
name field in YAML frontmatter, making them discoverable by
OpenCode skill tool.

New skills added: pre-flight, review-context, always-on-guidance,
forge-coordination, forge-global, learning-systems, replicator-cli,
system-design, testing-patterns. Commands, convention packs, and
OpenSpec schemas updated to latest scaffold versions.

Ref: unbound-force/unbound-force#316

Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Yvonne Devlin <ydevlin@redhat.com>
@yvonnedevlinrh yvonnedevlinrh requested a review from jflowers July 1, 2026 14:05
@yvonnedevlinrh yvonnedevlinrh self-assigned this Jul 1, 2026

@jflowers jflowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: #31 — chore: propagate skill name frontmatter fix

Verdict: APPROVE

CI passes. No production Go code changes — this is agent tooling scaffolding only. The core fix (adding name: frontmatter to all skills) is correctly applied across all 9 new/updated skills.

Findings

[MEDIUM] Convention pack listing incomplete in AGENTS.md, CLAUDE.md, and .cursorrules. All three list 4 packs (default.md, severity.md, content.md, go.md) but .opencode/uf/packs/ contains 11 files — missing python.md, typescript.md, and all *-custom.md packs. Non-blocking since this appears to be the intended uf init output and custom packs are loaded alongside their parent packs automatically.

[LOW] AGENTS.md lists content.md as a pack agents MUST read, but /review-pr (added in this PR) instructs reviewers to skip content packs. Minor contradiction — the specific command instruction overrides the general guidance.

Cleanup of duplicate <!-- scaffolded by ... --> markers and the [P] parallel task marker additions in OpenSpec templates are welcome improvements.

This review was generated by /review-pr (AI-assisted).

@yvonnedevlinrh yvonnedevlinrh merged commit faac705 into unbound-force:main Jul 2, 2026
1 check passed
@yvonnedevlinrh yvonnedevlinrh deleted the chore/skill-name-propagation branch July 2, 2026 08:13
@yvonnedevlinrh

Copy link
Copy Markdown
Contributor Author

Findings

[MEDIUM] Convention pack listing incomplete in AGENTS.md, CLAUDE.md, and .cursorrules.

Not actually a bug. The listing is intentionally selective, not incomplete:

  • collectDeployedPacks() starts with universal packs (default.md, severity.md, content.md, ci.md) and adds only the detected language pack (e.g., go.md for a Go project)
  • filterEmptyCustomPacks() strips out *-custom.md files that have no user-added content
  • The 11 files in the packs directory include python.md, typescript.md, and empty custom stubs — these are correctly excluded from the listing for a Go project
    So the listing showing 4 packs is working as designed

[LOW] AGENTS.md lists content.md as a pack agents MUST read, but /review-pr (added in this PR) instructs reviewers to skip content packs
Issue created in unbound-force repo unbound-force/unbound-force#322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review 👀

Development

Successfully merging this pull request may close these issues.

2 participants