fixing sortable DOs when ClickToToggle is enabled#58
Merged
unclecheese merged 2 commits intounclecheese:masterfrom Feb 2, 2016
dhensby:master
Merged
fixing sortable DOs when ClickToToggle is enabled#58unclecheese merged 2 commits intounclecheese:masterfrom dhensby:master
unclecheese merged 2 commits intounclecheese:masterfrom
dhensby:master
Conversation
Moving the class 'click to toggle' to the parent of the UL, so JS change reflects that
At the moment, ClickToToggle being enabled breaks the drag and drop reordoring due to some JS assumptions being made. I've moved the class set on the ul up to the parent to solve this problem
Contributor
Author
|
@unclecheese is this likely to be taken in or shall I close it off? |
Contributor
Author
unclecheese
pushed a commit
that referenced
this pull request
Feb 2, 2016
fixing sortable DOs when ClickToToggle is enabled
Owner
|
Sorry, there was a period of time when the email I use for Github had no MX records, and I missed several dozen notifications. In other news, how is this module still a thing? I'm so sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickToToggle allows the admins to toggle the selected state of a row by clicking the entire row of the DOM rather than just the checkbox or radio button.
This change broke drag and drop reordering because it added a class name to the
<ul>. That classname has now been moved to the parent div and the JS adjusted for this change.