Conversation
|
hey @zhu6201976 If it is not related to any issues, please specify the issue that this PR addresses, along with a sample code snippet. Once I have this information, I will review the pull request. Thank you! :) |
Hi @ntohidi, Thanks for the quick response! This PR specifically addresses Issue #1758. Problem: In Docker environments, saving screenshots to a local container path makes them inaccessible to the host machine/client without complex volume mounting. Solution: This PR modifies the MCP tool to return the Base64-encoded image data directly in the response, ensuring a "plug-and-play" experience for all MCP clients. Sample Code for Testing: Python Example MCP Tool Callresult = await p.call_tool( Looking forward to your review! |
OK. got it! let me review and check. Thanks :) |
|
Hi, thanks for your contribution! We're closing this PR as the codebase has changed significantly since it was opened and it now has merge conflicts with the current develop branch. If you'd like to re-submit against current develop, we'd be happy to review a fresh PR. Thanks for your effort! |
The Fix:
Instead of relying on the shared filesystem (which is problematic in Docker), this PR modifies the MCP tool to return the base64-encoded screenshot data directly in the API response.
Why:
Users running Crawl4AI in Docker cannot access the container's /tmp or internal paths without complex volume mapping. Returning the data directly makes the tool "plug-and-play" for all MCP clients (like Claude Desktop or custom agents).