Fix raw:// URL parsing logic

[jl-martins]

Summary

Fixes #1118

List of files changed and why

• crawl4ai/async_crawler_strategy.py - To fix the logic that converts raw URLs to raw HTML
• tests/20241401/test_async_crawler_strategy.py - To test the fix

How Has This Been Tested?

By implementing a parametrized test that calls AsyncPlaywrightCrawlerStrategy.crawl with a "raw:" and "raw://" URL and checks that the resulting HTML is correct.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added/updated unit tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of raw HTML input URLs, ensuring accurate extraction and processing of content for both "raw:" and "raw://" URL schemes.

• Tests

  • Added tests to verify correct processing of raw HTML input URLs and ensure the returned content matches the original HTML.

[coderabbitai]

Walkthrough

The code modifies the handling of raw HTML URLs in the crawler strategy to correctly strip both "raw:" and "raw://" prefixes when extracting HTML content. A new test and fixture are added to verify that both prefix variants are processed correctly and return the expected HTML.

Changes

File(s)	Change Summary
crawl4ai/async_crawler_strategy.py	Fixed logic to correctly strip "raw:" and "raw://" prefixes from raw HTML URLs in crawl method.
tests/general/test_async_crawler_strategy.py	Added fixture for basic HTML and a new async test to validate raw URL handling for both prefixes.

Sequence Diagram(s)

sequenceDiagram
    participant Test as test_raw_urls
    participant Strategy as AsyncPlaywrightCrawlerStrategy
    participant Response as AsyncCrawlResponse

    Test->>Strategy: crawl(raw:<html...> or raw://<html...>)
    alt URL starts with "raw://"
        Strategy->>Strategy: Extract HTML after "raw://"
    else URL starts with "raw:"
        Strategy->>Strategy: Extract HTML after "raw:"
    end
    Strategy->>Response: Return AsyncCrawlResponse(html)
    Test->>Test: Assert response.html == basic_html

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Correctly remove the entire "raw://" or "raw:" prefix from raw HTML URLs (#686)	✅
Ensure that crawling with "raw://" and "raw:" URLs returns the correct HTML content (#686)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

In the warren of code, a bug did dwell,
With slashes too many, things didn’t go well.
Now raw URLs are neat and trim,
The crawler hops with vigor and vim!
Tests confirm what rabbits knew—
Clean prefixes make results true.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 897e017 and 58c1e17.

📒 Files selected for processing (2)

• crawl4ai/async_crawler_strategy.py (1 hunks)
• tests/general/test_async_crawler_strategy.py (2 hunks)

🔇 Additional comments (3)

crawl4ai/async_crawler_strategy.py (1)

469-471: LGTM! Excellent fix for raw URL parsing logic.

The change correctly addresses the inconsistency between prefix detection and content extraction:

• Line 469: Simplified condition to check only "raw:" (which matches both "raw:" and "raw://")
• Line 471: Proper conditional logic that extracts content using the correct index (6 for "raw://", 4 for "raw:")

This ensures both raw URL formats are handled consistently and the HTML content is extracted correctly.

tests/general/test_async_crawler_strategy.py (2)

18-34: Well-structured test fixture.

The basic_html fixture provides clean, valid HTML content that's perfect for testing raw URL processing. The HTML structure includes proper elements (title, heading, main content) making it ideal for comprehensive testing.

---

346-351: Excellent parametrized test for both raw URL formats.

This test effectively verifies the fix by:

• Testing both "raw:" and "raw://" prefixes using parametrization
• Asserting exact HTML content match to ensure proper extraction
• Using the crawler strategy fixture to test the actual implementation

The test provides comprehensive coverage for the raw URL parsing fix and will catch any regressions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.