Add short CLI flag aliases, fix stake flags, and harden disk cache#4
Open
grubbhook wants to merge 5 commits intounconst:mainfrom
Open
Add short CLI flag aliases, fix stake flags, and harden disk cache#4grubbhook wants to merge 5 commits intounconst:mainfrom
grubbhook wants to merge 5 commits intounconst:mainfrom
Conversation
Follow-up to the hotkey flag rename: update reg.sh and two doc files that referenced the global --hotkey flag by its old name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
-e --endpoint, -d --wallet-dir, -H --hotkey-name, -o --output (-n/-w/-v/-y were already present; -h is reserved for --help) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…poll wait_for_finalized_success() requires GRANDPA finality which takes 36-72s on Bittensor (3-6 blocks × 12s), blowing past the 30s timeout even when the extrinsic was already successfully included in a block. Replace with a manual poll loop that resolves on TxStatus::InBestBlock (or InFinalizedBlock, whichever arrives first), then calls wait_for_success() to check for dispatch errors. In-block confirmation is sufficient to guarantee staking/transfer success — GRANDPA finality follows automatically. The 30s timeout is now appropriate: one block takes ~12s so 30s gives ample headroom without the false-failure behaviour. Fixes: transaction timed out after 30s despite successful on-chain inclusion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All threads shared the same .{key}-{pid}.tmp path, causing concurrent
writes to corrupt the temp file before rename. Add a global atomic
counter so each put() call gets a distinct tmp path.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
grubbhook
changed the title
Contributor
Author
|
Added a fix for ticket #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This ticket will resolve ticket #5 as well.
Related Issue