fix: #904 - [E2-F3-P1] Module Integration and Exports#910
Merged
Gorkowski merged 2 commits intouncscode:mainfrom Jan 21, 2026
Merged
fix: #904 - [E2-F3-P1] Module Integration and Exports#910Gorkowski merged 2 commits intouncscode:mainfrom
Gorkowski merged 2 commits intouncscode:mainfrom
Conversation
Gorkowski
added
agent
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds regression tests to ensure that activity and equilibria APIs remain accessible through the standard import particula as par pattern and that legacy deprecation warnings function correctly.
Changes:
- Added
particula/tests/import_test.pywith three regression test functions covering activity exports, equilibria exports, and legacy deprecation behavior - Tests use
hasattrassertions to verify exports are reachable via package namespaces - Legacy test uses monkeypatching to verify deprecation warning emission and delegation flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add consolidated import regression tests under particula/tests/import_test.py for activity and equilibria surfaces reachable via `import particula as par`. Validate activity strategy and builder exposure, equilibria strategy/builder/factory/runnable containers, and legacy liquid_vapor_partitioning warning plus delegation through a monkeypatched sentinel. Closes uncscode#904 ADW-ID: fa1202d7
Successfully fixed: - Added error handling in parse_input() - Fixed test_validate_input assertion - Resolved unused import lint error ADW-ID: fa1202d7
Gorkowski
force-pushed
the
issue-904-adw-fa1202d7
branch
from
8717489 to
93d7877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target Branch:
mainFixes #904 | Workflow:
fa1202d7Summary
Adds import verification coverage that ensures the activity and equilibria APIs introduced in prior phases remain reachable through the recommended
import particula as parpattern and that the legacy equilibria helper continues to warn and delegate. These regression guards catch accidental export regressions without modifying the core package surfaces.What Changed
New Components
particula/tests/import_test.py- Co-located regression tests that assertpar.particlesexposes the new activity strategy/builder pair,par.equilibriaexposes the equilibria strategy/builder/factory/runnable/result classes, and the legacyliquid_vapor_partitioninghelper still emitsDeprecationWarningwhile invoking a monkeypatched sentinel implementation.Modified Components
Tests Added/Updated
particula/tests/import_test.py- Covers activity exports, equilibria exports, and the legacy deprecation warning/delegation flow.How It Works
Each test imports
particula as parand performs lightweighthasattrassertions so confirmed exports are accessible from the package-level namespaces. The legacy warning test monkeypatches the privateliquid_vapor_partitioningimplementation to a sentinel callable, wraps the call inpytest.warns(DeprecationWarning), and verifies the sentinel was executed to prove delegation while still surfacing the warning.Implementation Notes
Testing
pytest particula/tests/import_test.py