Skip to content

Conversation

@under-Peter
Copy link
Owner

Benchmarks everything from the possible features with naive julia
implementations. Just to set the structure that all
branches/implementations should use to compare performance. While
comparison between commits/branches should be easy, within is less
trivial - e.g. comparing "Float64" with "Float32" across all operations
doesn't work by judge-ing SUITE[@tagged ...].

Could be merged to any branch that requires a benchmark-suite as soon as we're happy with the design.

Benchmarks everything from the possible features with naive julia 
implementations. Just to set the structure that all 
branches/implementations should use to compare performance. While 
comparison between commits/branches should be easy, within is less 
trivial - e.g. comparing "Float64" with "Float32" across all operations 
doesn't work by judge-ing SUITE[@tagged ...].
@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #8 into master will decrease coverage by 100%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #8     +/-   ##
=====================================
- Coverage     100%   0%   -100%     
=====================================
  Files           2    1      -1     
  Lines          30    1     -29     
=====================================
- Hits           30    0     -30     
- Misses          0    1      +1
Impacted Files Coverage Δ
src/OMEinsum.jl 0% <0%> (-100%) ⬇️
src/einsum.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6a317...60d4318. Read the comment docs.

Assign each function a unique name to avoid calling the wrong function 
with foo (as before) s.t. the whole thing runs smoothly.
@under-Peter under-Peter mentioned this pull request May 20, 2019
6 tasks
@GiggleLiu GiggleLiu merged commit 696b591 into master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants