Custom Thread Groups - Add support for IteratingController implement#714
Merged
undera merged 2 commits intoundera:masterfrom Apr 23, 2025
Merged
Conversation
Owner
|
@3dgiordano One question: does |
Contributor
Author
|
Hi @undera Apologies for not providing this information in the original PR documentation. I also forgot to mention that it was tested in JMeter 5.2.1 and later. |
Owner
|
Thank you for clarifications! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @undera
It was detected that the plugin is not using the IteratingController interface and is therefore not calling the updateIterationIndex method (in VirtualUserController).
The call to this method is responsible for creating the variable in the execution context with the value of the current iteration number of the running Thread Group.
Scripts that use this variable when migrating from Thread Group to some Thread Group in this plugin fail because the current implementation does not create that variable.
It is proposed to incorporate the use of the IteratingController interface in VirtualUserController to call updateIterationIndex to create that variable, just as the native Thread Group currently does with LoopController.
For the methods to be implemented with support for this interface, ideas were taken from JMeter's LoopController implementation (in an attempt to be aligned).
On JMeter 5.2-rc4 was added IteratingController and the updateIterationIndex method (apache/jmeter@b230954)
The change is aligned with the minimum requirement which is version 5.2.1
And the proposal implementation was also tested in JMeter 5.2.1+.
I look forward to your review, as well as any suggestions or changes you think are appropriate.
Regards
David