Custom Thread Groups - Reporting the correct value to updateIterationIndex#719
Merged
undera merged 1 commit intoundera:masterfrom May 14, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 3.1 of Custom Thread Groups, support for iteration variables was added.
It was reported that now that the iteration variable is reported, it doesn't follow the same pattern as ThreadGroup.
VirtualUserController has a different iteration numbering logic, which is why the first iteration is initialized with 1.
Therefore, when updateIterationIndex is called to store the iteration variable with the _idx value, it starts at 1, not 0 like ThreadGroup.
A small fix has been made to report it so that VirtualUserController reports the same way as the ThreadGroup controller (The iteration index is reported starting at zero).
It is proposed to adjust how the value is reported to updateIterationIndex so that the index used in the variables is appropriate, starting from zero.
Also fixed getIterCount to return the internal index without the increment, since VirtualUserController already internally enumerates iteration 1 as 1 and not zero (doesn't require the +1).