pop/smtp/tcp_server general cleanup to remove dead code #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commented out lines are a relic from when the base image was fedora, and were only useful for debugging. They never should have even been commited.
int this case, there is no function difference, but that is exactly why it is preferable, because when you are not using the additional features of the ADD instruction, why not make your intent clearer to the reader by using the unambigious and simpler COPY instruction.
Instead of needing to edit the makefile to uncomment the line that adds debugging options to the CFLAGS, just check if a make variable is defined so that consumers can specify `make DEBUG=true` to perform a debug build
charliemirabile
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where artifacts of the development process (commented out lines of code, antiquated approaches, etc) made it into the master branch. This PR cleans them up.