Enhanced rejection #275
Merged
Enhanced rejection #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theyoyojo
force-pushed
the
enhanced_rejection
branch
from
b98a202 to
357d0a9
Compare
charliemirabile
requested changes
Sep 5, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
I am still chewing on the first and last commits, but these are lower hanging fruit in terms of changes
theyoyojo
force-pushed
the
enhanced_rejection
branch
2 times, most recently
from
3c7c86e to
fd0093f
Compare
Grader can write to this section via the feedback ref on the relevant final submission tag, e.g.: $ git notes --ref=feedback add setup_final_bob -m 'Feedback message' Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
enhanced_rejection
branch
from
fd0093f to
3a63b87
Compare
Any patchset containing a hunk modifying a file outside of a directory named after their username at the top level of the submissions repository, as specified by the DCO in that particular patch, is rejected immediately upon submission. If no additional patchset is submitted before a deadline, the student will automatically receive a zero. Additionally, patches lacking a DCO at submission time are rejected. Fixes #145 Signed-off-by: Joel Savitz <joel@underground.software>
Run the peer review tags from denis/peer_review.py through the same run_automated_checks() as the initial and final tags, but skip the checks that don't make sense. This opens up the door for checking peer review specific requirements like the Acked-by and Nacked-by. Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
enhanced_rejection
branch
from
3a63b87 to
12465ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145