Conversation
|
Thank you! The flag is cool. But I'd really prefer to have a config for this. That'd match how tailwind and esbuild do things. So we can just set: And if not set we pick a default that is known to be good. So probably 9.4.0 if that was what worked for y'all. So we don't use the newest by default because that ensures they'll break people's stuff. And we make it easy to have the local command match CI because both would pick up the config. Not against having the flag as well but I think without the flag is probably straight up simpler? :) What do you think? |
|
Since this is just used as a CI tool I personally would want this to be as braindead simple as possible (I would really want to be able to just change the cspell version in the command from my CI config without having to create a config option for it). Adding a configuration option just for a tool I'm using in CI is, at least for me, not a feel good vibe, and also has the downside of hiding the configuration away from the command itself. Plus fwiw https://hexdocs.pm/elixir/design-anti-patterns.html#using-application-configuration-for-libraries |
Co-authored-by: Jon Carstens <jjcarstens@me.com>
|
Discussions were had! |
Since 9.6.0 was breaking things 😵