Skip to content

Allow cspell version to be pinned#2

Merged
lawik merged 3 commits intounderjord:mainfrom
kybishop:ky/allow-cspell-version-to-be-pinned
Jan 13, 2026
Merged

Allow cspell version to be pinned#2
lawik merged 3 commits intounderjord:mainfrom
kybishop:ky/allow-cspell-version-to-be-pinned

Conversation

@kybishop
Copy link
Copy Markdown
Contributor

Since 9.6.0 was breaking things 😵

Comment thread lib/mix/tasks/spellrider.check.ex Outdated
@lawik
Copy link
Copy Markdown
Contributor

lawik commented Jan 13, 2026

Thank you!

The flag is cool. But I'd really prefer to have a config for this. That'd match how tailwind and esbuild do things.

So we can just set:

# I want my things broken
config :spellweaver, cspell_version: "9.6.0"

And if not set we pick a default that is known to be good. So probably 9.4.0 if that was what worked for y'all.

So we don't use the newest by default because that ensures they'll break people's stuff. And we make it easy to have the local command match CI because both would pick up the config.

Not against having the flag as well but I think without the flag is probably straight up simpler? :)

What do you think?

@kybishop
Copy link
Copy Markdown
Contributor Author

kybishop commented Jan 13, 2026

Since this is just used as a CI tool I personally would want this to be as braindead simple as possible (I would really want to be able to just change the cspell version in the command from my CI config without having to create a config option for it). Adding a configuration option just for a tool I'm using in CI is, at least for me, not a feel good vibe, and also has the downside of hiding the configuration away from the command itself.

Plus fwiw https://hexdocs.pm/elixir/design-anti-patterns.html#using-application-configuration-for-libraries

Co-authored-by: Jon Carstens <jjcarstens@me.com>
@lawik
Copy link
Copy Markdown
Contributor

lawik commented Jan 13, 2026

Discussions were had!

Copy link
Copy Markdown
Contributor

@lawik lawik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, ship it :)

@lawik lawik merged commit 1d68a3b into underjord:main Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants