WooCommerce Style Fix#701
Merged
Thomas-A-Reinert merged 3 commits intounderstrap:masterfrom Jun 8, 2018
Merged
Conversation
Adds an scss file for any WooCommerce style issues that may arrise. This will allow users to comment out the style sheet if they are not using WooCommerce.
- WooCommerce Fix
Collaborator
|
Interesting with the conversion from transparent to rgba. Will definitely investigate |
Contributor
|
Guess why? If ANY browser has major problems with any standards which is that? The browser from hell: SAFARI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new SCSS file for WooCommerce. This way if anyone is not using WooCommerce they can easily remove it from their theme.
It also incorporates a fix for the wrapper
woocommerce-input-wrapperthat was added to billing fields. It's either this or we remove the wrapper.Reference:
#698
Notes:
gulp styleschanged one item fromtransparenttorgba(0, 0, 0, 0). I'm not sure why this occurred, but they are equivalent values. If anyone has information as to why, I would appreciate it.The exact changes were:
-webkit-tap-highlight-color: transparent; }-webkit-tap-highlight-color: rgba(0, 0, 0, 0); }Seems like it has to do with auto-prefix.