Skip to content

Duplicate revision task#729

Merged
holger1411 merged 2 commits intounderstrap:masterfrom
0dp:patch-8
Jul 2, 2018
Merged

Duplicate revision task#729
holger1411 merged 2 commits intounderstrap:masterfrom
0dp:patch-8

Conversation

@0dp
Copy link
Copy Markdown
Collaborator

@0dp 0dp commented Jun 28, 2018

I've removed the duplicate revision task.

Also revision was only called when trying to make a new dist. This is wrong, it should run every time a css or js file changes.

I've removed the duplicate revision task.

Also revision was only called when trying to make a new dist. This is wrong, it should run every time a css or js file changes.
@Thomas-A-Reinert
Copy link
Copy Markdown
Contributor

I´ll ignore that the travis thingie failed for whatever reason. Just copied it into my actual project and it pon running gulp watch-bs it now throws the following error for whatever reason.

[14:19:04] Using gulpfile X:\Flywheel\tumi\app\public\wp-content\themes\understrap\gulpfile.js
[14:19:04] Starting 'watch-bs'...
[14:19:04] 'watch-bs' errored after 12 ms
[14:19:04] ReferenceError: revision is not defined
    at X:\Flywheel\tumi\app\public\wp-content\themes\understrap\gulpfile.js:182:73
    at taskWrapper (X:\Flywheel\tumi\app\public\wp-content\themes\understrap\node_modules\undertaker\lib\set-task.js:13:15)
    at bound (domain.js:301:14)
    at runBound (domain.js:314:12)
    at asyncRunner (X:\Flywheel\tumi\app\public\wp-content\themes\understrap\node_modules\async-done\index.js:55:18)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

But I can see this task in line 148.. ?!

@0dp
Copy link
Copy Markdown
Collaborator Author

0dp commented Jun 29, 2018

I just updated the patch, and tested. It works in my end

@holger1411 holger1411 merged commit 1995522 into understrap:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants