Skip to content

Conversation

@nbiton
Copy link
Contributor

@nbiton nbiton commented Oct 1, 2019

@kaihendry I moved some code around to create a uni-directional dependency between two major modules, as for some reason, Puppeteer can't resolve code with bi-directional dependency as well as the Meteor runtime. Tests are running fine after these changes,

@nbiton nbiton requested a review from kaihendry October 1, 2019 12:48
@kaihendry
Copy link
Contributor

·[0m·[91mnpm ·[0m·[91mERR!·[0m·[91m Could not install from "node_modules/meteor-node-stubs/readable-stream@git+https:/github.com/meteor/readable-stream.git#2e9112d7d31a2af6e0682db0e18679b1e5fd4694" as it does not contain a package.json file.

I also see that ·[0mThe command '/bin/sh -c meteor npm install --save postcss-easy-import' returned a non-zero code: 1 is not failing in the Docker build in the AWS CodeBuild job.

Can you check the Docker build works along with the changes to make npm t work?

Copy link
Contributor

@kaihendry kaihendry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbiton nbiton merged commit 5d9f461 into unee-t:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants