feat: add media-player stable_id_support option#80
Merged
Conversation
The reason for this option is for integrations like Roon that support stable media IDs with a costly workaround for browsing but not for searching. When using media browsing or searching for selecting a media for immediate playback, then it doesn't matter and stable IDs are not required. But when using it for a play-command in a sequence or as a UI command, a stable media-ID is required. This new option allows disabling the search feature in the play-media command selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this option is for integrations like Roon that support stable media IDs with a costly workaround for browsing but not for searching. When using media browsing or searching for selecting a media for immediate playback, then it doesn't matter and stable IDs are not required. But when using it for a play-command in a sequence or as a UI command, a stable media-ID is required.
This new option allows disabling the search feature in the play-media command selection.