refactor: add named parameter support for events, provide websocket#49
Merged
refactor: add named parameter support for events, provide websocket#49
Conversation
Provide the `websocket` handle in events. This allows the integration driver to send request messages to the Remote. Furthermore, external integration driver can keep track of multiple Remote connections. Event listeners are wrapped for compatibility: existing event handlers without parameters still work. BREAKING CHANGE: client event handler using parameters must use the named parameter names. This mainly affects SUBSCRIBE_ENTITIES and UNSUBSCRIBE_ENTITIES: the parameter must be named `entity_ids`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide the
websockethandle in events. This allows the integration driver to send request messages to the Remote.Furthermore, external integration driver can keep track of multiple Remote connections.
Event listeners are wrapped for compatibility: existing event handlers without parameters still work.
BREAKING CHANGE: client event handler using parameters must use the named parameter names.
This mainly affects SUBSCRIBE_ENTITIES and UNSUBSCRIBE_ENTITIES: the parameter must be named
entity_ids.An integration is free to choose which parameters are required. Example:
This change is required for PR #47