-
-
Notifications
You must be signed in to change notification settings - Fork 20
chore: update deps #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #120
Conversation
WalkthroughDependency version updates across four template package.json files: UI/ano devDependency @iconify-json/tabler to ^1.2.22, UI/skiyee dependency @skiyee/uni-ui to ^1.0.0, config/typescript devDependencies @types/node to ^24.3.0 and @vue/tsconfig to ^0.8.0, and module/unocss devDependency @iconify-json/carbon to ^1.2.13. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/core/template/UI/ano/package.json (1)
1-8: Align iconify-json versions across templatesI see two iconify-json packages in templates with different versions:
- packages/core/template/module/unocss/package.json
• “@iconify-json/carbon”: “^1.2.13”- packages/core/template/UI/ano/package.json
• “@iconify-json/tabler”: “^1.2.22”To improve caching and reduce duplicate downloads, bump Carbon to match Tabler:
--- packages/core/template/module/unocss/package.json @@ devDependencies - "@iconify-json/carbon": "^1.2.13", + "@iconify-json/carbon": "^1.2.22",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
packages/core/template/UI/ano/package.json(1 hunks)packages/core/template/UI/skiyee/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)packages/core/template/module/unocss/package.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/core/template/UI/skiyee/package.json (1)
packages/core/template/UI/nut/vite.config.js.data.mjs (1)
plugin(23-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
🔇 Additional comments (5)
packages/core/template/module/unocss/package.json (1)
3-3: LGTM: bump @iconify-json/carbon to ^1.2.13Safe, non-breaking dev-only asset update. No concerns here.
packages/core/template/config/typescript/package.json (2)
6-7: LGTM: @types/node ^24.3.0 and @vue/tsconfig ^0.8.0 bumpsBoth are minor/patch updates and should be low risk alongside typescript ^5.9.2 and vue-tsc ^3.0.5.
1-11: Sanity‐check type config compatibility across all TS templatesWe’ve bumped
@vue/tsconfig→0.8.0,typescript→5.9.2 &vue-tsc→3.0.5 in the TypeScript template’s package.json. Even minor version bumps can tweak defaults (lib targets, moduleResolution, etc.), so please:
- Run
pnpm installand commit the updated pnpm-lock.yaml.- Execute
vue-tsc --noEmitin eachpackages/core/template/**directory to ensure no regressions.- If any template’s tsconfig extends
@vue/tsconfigand type-check breaks, explicitly pin the affectedcompilerOptions(e.g.lib,moduleResolution).packages/core/template/UI/skiyee/package.json (1)
3-3: Peer dependencies and plugin configuration are aligned for v1.0.0
- @skiyee/uni-ui@1.0.0 peerDependencies include
@skiyee/ui-preset≥ 0.0.5, and the template’s devDependency"@skiyee/ui-preset": "^0.0.5"satisfies this.- No peer requirement on
@skiyee/ui-resolverin uni-ui@1.0.0, and the template’s"@skiyee/ui-resolver": "^0.0.2"remains compatible.autoImportSkiyeeUiPlugin(id:'skiyee-ui') and the presets/resolvers importer syntax invite.config.jsanduno.config.jsmatch the v1 API.No changes needed.
packages/core/template/UI/ano/package.json (1)
6-6: LGTM: bump @iconify-json/tabler to ^1.2.22Minor, non-breaking icon set update. Looks good.
| "@iconify-json/carbon": "^1.2.11", | ||
| "@iconify-json/carbon": "^1.2.13", | ||
| "@uni-helper/unocss-preset-uni": "^0.2.11", | ||
| "unocss": "66.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Double-check unocss version "66.0.0" (likely invalid/typo)
UnoCSS versions are typically 0.xx.x; "66.0.0" looks suspicious and may break installs for template consumers.
Run this to confirm published versions and the current dist-tag:
If it’s indeed invalid, update to the latest stable (e.g., "^0.66.0" if that matches the registry) and align any @unocss/* peer deps accordingly. I can prep a follow-up patch if you confirm the intended target.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Dist-tags for unocss:"
curl -s https://registry.npmjs.org/unocss | jq '."dist-tags"'
echo -e "\nLast 10 published versions:"
curl -s https://registry.npmjs.org/unocss | jq -r '.versions | keys | .[-10:][]'Length of output: 392
Fix unocss version in template’s package.json
The version "66.0.0" doesn’t exist on npm (latest is 66.4.2), so installs will fail. Update to the published version:
- File: packages/core/template/module/unocss/package.json (line 5)
- "unocss": "66.0.0"
+ "unocss": "^66.4.2"Also ensure any @unocss/* peerDependencies match this version.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "unocss": "66.0.0" | |
| "unocss": "^66.4.2" |
🤖 Prompt for AI Agents
In packages/core/template/module/unocss/package.json around line 5, the template
pins "unocss" to a non-existent version "66.0.0" which will break installs;
update the "unocss" entry to a published version (e.g. "66.4.2") and then audit
the package.json for any @unocss/* peerDependencies and update their versions to
match the same published semver (or use a compatible range like ^66.4.2) so all
unocss packages are consistent.
Update dependencies
Summary by CodeRabbit
New Features
Chores
Bug Fixes