chore: update deps #135
chore: update deps #135
Conversation
WalkthroughMultiple package.json files update dependency versions across UI templates, config templates, and plugin templates. No code, logic, or public API changes are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
packages/core/template/UI/ano/package.json(1 hunks)packages/core/template/UI/nut/package.json(1 hunks)packages/core/template/config/lint/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)packages/core/template/plugin/import/package.json(1 hunks)packages/core/template/plugin/pages/package.json(1 hunks)packages/core/template/plugin/root/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (-t vitesse, 20.x, windows-latest)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-apple-darwin - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
🔇 Additional comments (6)
packages/core/template/UI/ano/package.json (1)
6-6: LGTM: safe icon metadata bump.No impact expected on runtime or build.
packages/core/template/config/lint/package.json (1)
8-8: ESLint 9.x bump — confirm Node engine & flat-config compatibilitynpm shows eslint@^9.36.0 requires node "^18.18.0 || ^20.9.0 || >=21.1.0". Ensure packages/core/template/config/lint/package.json (and template engines/CI Node versions) meet that range and that any flat config remains valid; approve after confirmation.
packages/core/template/UI/nut/package.json (1)
3-3: Check NutUI peer deps & release notes.
packages/core/template/UI/nut/package.json (line 3) -> "nutui-uniapp": "^1.9.1".
Peer deps for nutui-uniapp@^1.9.1: vue >=3.2.0; @uni-helper/uni-app-types ^1.0.0-alpha.6.
Ensure the project’s Vue/uni-app versions satisfy these and review NutUI changelog/release notes for any CSS-variable changes/migration steps.packages/core/template/plugin/root/package.json (1)
3-3: Validate @uni-ku/root requirements
- npm view shows @uni-ku/root peerDependency: vite ^5.0.0 and no "engines" returned — check packages/core/template/plugin/root/package.json (line 3).
- Action: ensure the template/project uses Vite ≥5 or pin to a compatible @uni-ku/root; review @uni-ku/root v1.4.0 changelog for breaking/minor-bump changes and confirm Node version expectations (add/update "engines" or docs if needed).
packages/core/template/plugin/pages/package.json (1)
3-3: Ensure Vite compatibility — plugin requires Vite ^5.0.0File: packages/core/template/plugin/pages/package.json (lines 3-3)
"@uni-helper/vite-plugin-uni-pages": "^0.3.15"npm shows peerDependencies: {"vite":"^5.0.0"}. Verify the repository's Vite version (and Uni runtime) is compatible with Vite ^5.0.0; if not, upgrade Vite or pin a plugin version that matches your Vite/Uni stack.
packages/core/template/plugin/import/package.json (1)
3-3: Verify peerDependencies for @uni-helper/vite-plugin-uni-components (^0.2.1)
npm view returned no output — unable to confirm peerDependencies/engines for ^0.2.1. Run locally: npm view @uni-helper/vite-plugin-uni-components@^0.2.1 peerDependencies engines --json or check the package's npm/GitHub page; ensure the plugin's peer deps are compatible with the project's Vite/Uni versions (packages/core/template/plugin/import/package.json, line 3).
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^24.5.1", | ||
| "@types/node": "^24.5.2", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
🧩 Analysis chain
Align Node type defs with target runtime.
Make sure template “engines.node” (if any) matches @types/node major.
🏁 Script executed:
#!/bin/bash
# Inspect declared Node engines across templates (if present)
fd -t f package.json | xargs -I{} sh -c 'jq -r "[input_filename, (.engines.node // \"\")]|@tsv" < "{}"' | awk -F'\t' '$2!=""'Length of output: 84
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file='packages/core/template/config/typescript/package.json'
echo "CHECK: specific template package.json"
if [[ -f "$file" ]]; then
engine=$(jq -r '.engines.node // empty' "$file")
typesnode=$(jq -r '.devDependencies["@types/node"] // .dependencies["@types/node"] // empty' "$file")
printf '%s\tengines:%s\t@types/node:%s\n' "$file" "${engine:-<NO_ENGINES>}" "${typesnode:-<NO_TYPES_NODE>}"
else
echo "MISSING_FILE: $file"
fi
echo
echo "SCAN: all package.json files for engines.node and @types/node"
find . -type f -name package.json -print0 | while IFS= read -r -d '' f; do
engine=$(jq -r '.engines.node // empty' "$f")
typesnode=$(jq -r '.devDependencies["@types/node"] // .dependencies["@types/node"] // empty' "$f")
if [[ -n "$engine" || -n "$typesnode" ]]; then
printf '%s\tengines:%s\t@types/node:%s\n' "$f" "${engine:-<NO_ENGINES>}" "${typesnode:-<NO_TYPES_NODE>}"
fi
doneLength of output: 862
Align Node engine with @types/node major
- packages/core/template/config/typescript/package.json declares "@types/node": "^24.5.2" but has no "engines.node".
- Repo root ./package.json uses "@types/node": "^18.19.50" and several gui packages set "engines": ">= 10" — Node targets are inconsistent.
- Action: pick the intended Node runtime and either add/update "engines.node" in the template to match @types/node major 24, or change the template's @types/node to the repository's chosen Node major.
Update dependencies
Summary by CodeRabbit