data-* attributes don't work with withUniwind

[peterlazar1993]

What happened?

The data-selectors support is awesome! I was hoping uniwind can also add support for:

1. aria-selectors
2. data/aria selectors for HOC components

Currently components wrapped with withUniwind HOC does not support data-selectors

Steps to Reproduce

Pull down repo and run the app in expo go

Snack or Repository Link

https://github.com/peterlazar1993/selectors

Uniwind version

1.6.0

React Native Version

0.83.2

Platforms

Android, iOS

Expo

Yes

Additional information

• I've searched for similar issues in this repository and found none

[Brentlok]

Hi, nice catch. We've missed handling data attributes in withUniwind

I'm not sure about adding support for aria selectors though, could you share your use case?

[peterlazar1993]

@Brentlok
I am trying to style Pressable's children (Text/Icon) based on the Pressable's state.

Looking at the possibilities:

• dynamic class names based on the Pressable's render prop (works but verbose)
• data-* selectors on child text from the render prop (works for Text, not for withUniwind(Icon))
• aria-* selectors (not supported)
• group-* selectors (not supported)

I personally don't need aria-* selectors, but would be nice to have I guess.

What I really need is group-*, I see it's marked as WIP so looking forward to it.

[peterlazar1993]

By the way, you should consider exporting a function for makePressable so that I can use Pressable from RNGH.
uniwindifying Pressable without access to internals is not possible currently.

[Brentlok]

So we're not going to support aria attributes, those are not even supported by react native.

By the way, you should consider exporting a function for makePressable so that I can use Pressable from RNGH.
uniwindifying Pressable without access to internals is not possible currently.

The issue is about different thing, feel free to open a discussion. I don't want to mix topics because it's later harder for everyone to find if this was discussed before